Wireshark · Wireshark-commits: [Wireshark-commits] master b4762a0: Generate Diameter's expert info's even when there's no tree so t

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b4762a043458e5205090282a099184980fb555ea
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b4762a0 by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    Generate Diameter's expert info's even when there's no tree so that they show
    up in the Expert Infos dialog.
    
    Push the if(tree) check down into the basic type dissectors since we can't
    generate/fill the label (which won't be used anyway) when we're not building
    the tree (since the proto_item will be faked/NULL).
    
    Change-Id: Ie4f1f6856cfad0dabc7c58cdee2c16c8fc032c6d
    Reviewed-on: https://code.wireshark.org/review/10001
    Petri-Dish: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  dc4e960   Add some Gx AVPs from 3GPP 29.212.
    adds  b4762a0   Generate Diameter's expert info's even when there's no tree so that they show up in the Expert Infos dialog.


Summary of changes:
 epan/dissectors/packet-diameter.c |  210 +++++++++++++++++++++----------------
 1 file changed, 122 insertions(+), 88 deletions(-)