Wireshark-commits: [Wireshark-commits] master 2ed3d91: Add the WLAN statistics dialog.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 20 Aug 2015 23:12:44 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2ed3d91b45332a2cbb4114b61f18c80fb28a6840
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2ed3d91 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Add the WLAN statistics dialog.
    
    Instead of splitting the stats into two lists as with the GTK+ UI, add
    everything to an expandable tree. This allows viewing nodes on more than
    one network.
    
    Rename the top-level Bluetooth menu item to Wireless and put the WLAN
    stats dialog there.
    
    The Qt UI matches SSIDs (WlanNetworkTreeWidgetItem::isMatch) a bit
    differently than the GTK+ UI. Try to make the logic as plain as possible
    since we'll likely have to update it in the future.
    
    The addition of a custom BSSID address types means that we can't assume
    that everything is AT_ETHER. Add routines for checking for broadcast
    BSSIDs and comparing only the data portions of addresses.
    
    Move PercentBarDelegate into its own module. Use it in
    WlanStatisticsDialog.
    
    Change-Id: Ie4214eb00671a890871380c4a07213ebfb7585c6
    Reviewed-on: https://code.wireshark.org/review/10171
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  0f9bbbc   BOOTP: fix indent (use tab)
    adds  2ed3d91   Add the WLAN statistics dialog.


Summary of changes:
 epan/address.h                                     |   19 +
 epan/dissectors/packet-ieee80211.c                 |   16 +-
 epan/dissectors/packet-ieee80211.h                 |   17 +-
 epan/wslua/taps                                    |    2 +-
 ui/gtk/wlan_stat_dlg.c                             |   24 +-
 ui/qt/CMakeLists.txt                               |    4 +
 ui/qt/Makefile.common                              |   15 +-
 ui/qt/Wireshark.pro                                |    9 +-
 ui/qt/main_window.h                                |    3 +
 ui/qt/main_window.ui                               |   18 +-
 ui/qt/main_window_slots.cpp                        |   16 +-
 ui/qt/multicast_statistics_dialog.cpp              |    7 +-
 ...kline_delegate.cpp => percent_bar_delegate.cpp} |   84 +--
 ...sparkline_delegate.h => percent_bar_delegate.h} |   22 +-
 ui/qt/protocol_hierarchy_dialog.cpp                |   55 --
 ui/qt/protocol_hierarchy_dialog.h                  |   23 +-
 ui/qt/wlan_statistics_dialog.cpp                   |  679 ++++++++++++++++++++
 ...tats_tree_dialog.h => wlan_statistics_dialog.h} |   42 +-
 18 files changed, 848 insertions(+), 207 deletions(-)
 copy ui/qt/{sparkline_delegate.cpp => percent_bar_delegate.cpp} (50%)
 copy ui/qt/{sparkline_delegate.h => percent_bar_delegate.h} (76%)
 create mode 100644 ui/qt/wlan_statistics_dialog.cpp
 copy ui/qt/{stats_tree_dialog.h => wlan_statistics_dialog.h} (63%)