Wireshark-commits: [Wireshark-commits] master 4abec47: Clean up handling of time stamps.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 18 Aug 2015 19:18:03 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4abec47c053491a55ef0fca8750af2d363033421
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

4abec47 by Guy Harris (guy@xxxxxxxxxxxx):

    Clean up handling of time stamps.
    
    Use common code for all time stamps, so it's handled the same for the
    Packet Block, Enhanced Packet Block, and Interface Statistics Block.
    
    Show the high and low parts of the time stamp as fields; file dissectors
    should show the raw file details.  Mark the calculated time stamp as
    generated, as it's not the raw file data.
    
    Get the 64-bit time stamp by shifting the high part left 32 bits and
    ORing in the low part; no need to play games with unions and byte order
    
    Change-Id: I19b2c3227a3ca1e93ec653f279136aa18687581f
    Reviewed-on: https://code.wireshark.org/review/10116
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  ea7cf08   Cast away 64 -> 32 narrowing complaints.
    adds  4abec47   Clean up handling of time stamps.


Summary of changes:
 epan/dissectors/file-pcapng.c |  101 +++++++++++++++++++++++------------------
 1 file changed, 58 insertions(+), 43 deletions(-)