Wireshark-commits: [Wireshark-commits] master 1b46738: Do the "plugin" menu stuff in one pass.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 15 Aug 2015 18:21:09 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1b467383de7aa2ea79b29fa552de35a4353ec921
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

1b46738 by Guy Harris (guy@xxxxxxxxxxxx):

    Do the "plugin" menu stuff in one pass.
    
    Also, use g_strconcat() in other places where we prepend / to action
    names.
    
    Hopefully, this will make it easier to find common code between all the
    N different places where we add menus and menu items.
    
    Change-Id: Iee876866730cada64428df17f1f3c4552cc3ac93
    Reviewed-on: https://code.wireshark.org/review/10048
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  c222719   Fix creation of menu actions in ws_menubar_create_action_group().
    adds  1b46738   Do the "plugin" menu stuff in one pass.


Summary of changes:
 ui/gtk/main_menubar.c |   91 ++++++++++++++-----------------------------------
 1 file changed, 25 insertions(+), 66 deletions(-)