Wireshark-commits: [Wireshark-commits] master 8368f3b: Update the previously-added comment.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 15 Aug 2015 04:00:05 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8368f3b7f0b59cdb41a2a91543d7e01ff10afb06
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8368f3b by Guy Harris (guy@xxxxxxxxxxxx):

    Update the previously-added comment.
    
    At least with kqueues, NOTE_REVOKE is delivered if the file system
    containing the vnode in question is unmounted, and that gets mapped to a
    change notification by QFileSystemWatcher, so the right thing should
    happen.
    
    I'm not sure whether the right thing happens on Windows.
    
    Change-Id: I1e4c0d510f31f68d574c4d4cf20524666382930f
    Reviewed-on: https://code.wireshark.org/review/10039
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  463caf8   Discuss alternatives to polling all the recent files every 2 seconds.
    adds  8368f3b   Update the previously-added comment.


Summary of changes:
 ui/qt/wireshark_application.cpp |   69 ++++++++++++++++-----------------------
 1 file changed, 29 insertions(+), 40 deletions(-)