Wireshark-commits: [Wireshark-commits] master 14c7525: [Qt Expert Info dialogue] remove our tap lis
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 11 Aug 2015 21:27:22 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=14c75250ab484b8ff872a88f6c9a826dd3cce4d8
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

14c7525 by Martin Kaiser (wireshark@xxxxxxxxx):

    [Qt Expert Info dialogue] remove our tap listener when the dialogue is destroyed
    
    if we don't do this, there'll be a dangling tap listener and we'll see a
    crash when its reset method is called
    
    this can be triggered by opening another expert info dialogue, this will
    invoke cf_retap_packets() and reset_tap_listeners() which in turn calls
    the reset method of each registered tap listener
    
    Bug: 11432
    Change-Id: I8fc13351666c875e1a3641f31bada8e80d167ab2
    Reviewed-on: https://code.wireshark.org/review/9979
    Petri-Dish: Martin Kaiser <wireshark@xxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  f1a4db3   Lua: Remove unneeded call in wslua_cleanup
    adds  14c7525   [Qt Expert Info dialogue] remove our tap listener when the dialogue is destroyed


Summary of changes:
 ui/qt/expert_info_dialog.cpp |    1 +
 1 file changed, 1 insertion(+)