Wireshark-commits: [Wireshark-commits] master 9557c73: Make sure per-packet tap callbacks return gb
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 3 Aug 2015 03:06:20 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9557c73f81efad68ce3961a5ec18de2d985c4bb1
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

9557c73 by Gerald Combs (gerald@xxxxxxxx):

    Make sure per-packet tap callbacks return gbooleans.
    
    The tap API changed the return type of per-packet listener callbacks
    from int to gboolean back in 2009. Update a bunch of functions and some
    documentation accordingly.
    
    Change-Id: I79affe65db975caed3cc296a7e2985b7b9cdf4cc
    Reviewed-on: https://code.wireshark.org/review/9853
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  08e80b1   Skip files larger than 8MB in valgrind fuzzing
    adds  9557c73   Make sure per-packet tap callbacks return gbooleans.


Summary of changes:
 doc/README.tapping             |    8 ++------
 epan/wslua/wslua_listener.c    |    8 ++++----
 ui/cli/tap-expert.c            |   10 +++++-----
 ui/cli/tap-icmpstat.c          |   14 +++++++-------
 ui/cli/tap-icmpv6stat.c        |   14 +++++++-------
 ui/gtk/expert_comp_dlg.c       |    6 +++---
 ui/gtk/follow_ssl.c            |    6 +++---
 ui/gtk/follow_udp.c            |    4 ++--
 ui/qt/follow_stream_dialog.cpp |    8 ++++----
 ui/tap-sctp-analysis.c         |    4 ++--
 ui/tap_export_pdu.c            |    2 +-
 11 files changed, 40 insertions(+), 44 deletions(-)