Wireshark-commits: [Wireshark-commits] master 83dc308: PCLI: Expand protocol support
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 22 Jul 2015 01:28:51 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=83dc308f3681a28ee943e771e3b93117901ca231
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

83dc308 by Luke Mewburn (luke@xxxxxxxxxxx):

    PCLI: Expand protocol support
    
    1. Implement "Decode As" for PCLI payload instead of assuming IP.
       Currently supported subdissectors are Ethernet and IP.
    
    2. Implement multiple "flavors" of PCLI with different header formats:
            pcli: 4 byte CCCID
            pcli8: 8 byte header (including CCCID)
            pcli12: 4 byte CCCID, 8 byte NTP timestamp
            pcli20: 4 byte CCCID, 8 byte NTP timestamp, 8 byte case ID
       All flavors currently using "Decode As" for payload.
    
    3. Optionally append CCCID to protocol item in tree
       using preference "pcli.summary_in_tree".
    
    4. Obsolete preference "pcli.udp_port".
    
    Bug: 9266
    Bug: 11220
    
    Change-Id: Ie4bca06665985ef1eb77db767771a5a82357e242
    Reviewed-on: https://code.wireshark.org/review/8608
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Petri-Dish: Evan Huus <eapache@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  6e7f302   Translation (Qt): fix typo
    adds  83dc308   PCLI: Expand protocol support


Summary of changes:
 epan/dissectors/packet-eth.c  |    2 +
 epan/dissectors/packet-ip.c   |    1 +
 epan/dissectors/packet-pcli.c |  200 ++++++++++++++++++++++++++++++++---------
 3 files changed, 160 insertions(+), 43 deletions(-)