Wireshark-commits: [Wireshark-commits] master-1.12 f03593a: Use expert info to report unknown TLV t
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 17 Jul 2015 07:25:45 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f03593acd6668a4bc151d45d7dd7370a51fefc35
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

f03593a by Guy Harris (guy@xxxxxxxxxxxx):

    Use expert info to report unknown TLV types.
    
    Unless we plan to fill in all 256 entries in the TLV type table, and
    unless that's because all 256 types are valid, we should report unknown
    types with an expert info, not a dissector assertion.
    
    Change-Id: Ia6fca37ad6a5969caad3229abaf08a25e20ba992
    Reviewed-on: https://code.wireshark.org/review/3707
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 9d6d19254cd7e264fcc886ec24b505ebd6156109)
    Reviewed-on: https://code.wireshark.org/review/9681
    

Actions performed:

    from  1abc148   wmem: don't remove tiny blocks from the recycler
    adds  f03593a   Use expert info to report unknown TLV types.


Summary of changes:
 epan/dissectors/packet-gsm_abis_oml.c |   23 ++++++++++++++++++-----
 1 file changed, 18 insertions(+), 5 deletions(-)