Wireshark-commits: [Wireshark-commits] master acbbce9: Fix Windows CMake PortableApps dependencies
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 25 Jun 2015 22:02:21 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=acbbce9ffbec7078e832cf4d780fdcc464ea2c7d
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

acbbce9 by Graham Bloice (graham.bloice@xxxxxxxxxxxxx):

    Fix Windows CMake PortableApps dependencies
    
    The nsis_uninstall target appears to create a temporary file
    uninstaller_installer.exe that is renamed to uninstall.exe
    
    The above rename upsets the portableapps_app_dir target that is
    copying files from the CMake run dir into the portable apps dir.
    
    The change adds a dependency on nsis_uninstall to the portableapps_package
    target in an attempt to sequence the copy operation.
    
    Change-Id: I9feb55599eff000f983c23ce29c89fbd3be0a6ac
    Reviewed-on: https://code.wireshark.org/review/9153
    Reviewed-by: Graham Bloice <graham.bloice@xxxxxxxxxxxxx>
    Petri-Dish: Graham Bloice <graham.bloice@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  6122b4b   Qt: when a capture file is closed, go back to the welcome screen only if we're not capturing to multiple files
    adds  acbbce9   Fix Windows CMake PortableApps dependencies


Summary of changes:
 packaging/portableapps/CMakeLists.txt |    1 +
 1 file changed, 1 insertion(+)