Wireshark-commits: [Wireshark-commits] master 419f672: Replace Folder.CopyHere with 7-Zip.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 25 Jun 2015 18:58:39 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=419f67209d0e7d840124f1df31a153a36436f809
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

419f672 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Replace Folder.CopyHere with 7-Zip.
    
    Server Core editions of Windows don't have shell.application. As a result
    CopyHere and its unzip capabilities aren't guaranteed to be available.
    Plus, CopyHere is just plain slow.
    
    Remove the CopyHere code. Search for 7z and 7za in various places and
    download the standalone 7za if needed.
    
    Bug: 11151
    Change-Id: Ie719effbdcee3141764183bf3535ec9bd1c3e97a
    Reviewed-on: https://code.wireshark.org/review/8226
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  78e71f6   Remove the other g_hash_table_contains
    adds  419f672   Replace Folder.CopyHere with 7-Zip.


Summary of changes:
 tools/win-setup.ps1 |   70 +++++++++++++++++++++++++++++++++++++++++++--------
 1 file changed, 59 insertions(+), 11 deletions(-)