Wireshark-commits: [Wireshark-commits] master acc5810: Plugin Interface: Add GUI callbacks
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 25 Jun 2015 16:23:15 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=acc581081e84c93e878a678fbb3655aba253607a
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

acc5810 by Roland Knall (roland.knall@xxxxxxxxxxxxxxxxx):

    Plugin Interface: Add GUI callbacks
    
     Rename ext_menubar to a more appropriate plugin_if.
    
     External menus can be implemented by plugins to present
     additional menus for deep-packet analysis. One side-effect
     of such menus being implemented as plugins is, that they
     are being executed in different threads and therefore can
     only use limited access to the main GUI. Also, there is
     no safe cross-gui (GTK and Qt) way for many features.
    
     This patch implements a first functionality, by which a
     plugin implemented using ext_menubar can apply a display
     filter to the main view.
    
     For now the implementation supports filtering, as well as
     saving a preference.
    
    Change-Id: Iffe4caa954bbeb8ce356352de4dae348a50efba9
    Reviewed-on: https://code.wireshark.org/review/8773
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  d4aa1a1   Qt: mark unused parameters as such
    adds  acc5810   Plugin Interface: Add GUI callbacks


Summary of changes:
 doc/README.plugins                  |   26 ++++++++--
 epan/CMakeLists.txt                 |    2 +-
 epan/Makefile.common                |    4 +-
 epan/{ext_menubar.c => plugin_if.c} |   89 +++++++++++++++++++++++++++++++++--
 epan/{ext_menubar.h => plugin_if.h} |   42 ++++++++++++++---
 ui/gtk/main_filter_toolbar.c        |   24 ++++++++++
 ui/gtk/main_menubar.c               |    2 +-
 ui/gtk/packet_list.c                |   24 ++++++++++
 ui/preference_utils.c               |   42 +++++++++++++++++
 ui/preference_utils.h               |   10 ++++
 ui/qt/main_window.cpp               |   44 ++++++++++++++++-
 ui/qt/main_window.h                 |    2 +-
 12 files changed, 292 insertions(+), 19 deletions(-)
 rename epan/{ext_menubar.c => plugin_if.c} (64%)
 rename epan/{ext_menubar.h => plugin_if.h} (81%)