Wireshark-commits: [Wireshark-commits] master 7e62a03: fix the 'then' statement is equivalent to th
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 25 Jun 2015 15:41:00 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7e62a038304c8aee01b732ffcf89b205ad730a3d
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7e62a03 by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    fix the 'then' statement is equivalent to the 'else' statement found by PVS Studio (V523)
    
    Change-Id: I016e69f43bad98eb0604852ea658adaa5fe77c12
    Reviewed-on: https://code.wireshark.org/review/8786
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  3f5d183   Stop using atof/strtod (fixes column sorting of float types)
    adds  7e62a03   fix the 'then' statement is equivalent to the 'else' statement found by PVS Studio (V523)


Summary of changes:
 epan/dissectors/packet-ber.c   |    9 +--------
 epan/dissectors/packet-cigi.c  |    6 +-----
 epan/dissectors/packet-smb.c   |   20 +++++---------------
 epan/dissectors/packet-spice.c |   13 ++++---------
 4 files changed, 11 insertions(+), 37 deletions(-)