Wireshark · Wireshark-commits: [Wireshark-commits] lts-1.12.1 ce1ac2c: WCCP: Fix up storing and decoding of IP addresses.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ce1ac2c12a71de7a0eac4710383298875fb457a8
Submitter: Balint Reczey (balint@xxxxxxxxxxxxxxx)
Changed: branch: lts-1.12.1
Repository: wireshark

Commits:

ce1ac2c by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    WCCP: Fix up storing and decoding of IP addresses.
    
    Try to decode as many IP addresses as we can, even if they don't fit in the
    table we store them in.
    
    Only add IP addresses in the table once.  We could theoretically reallocate
    the table but the original code seems to assume the addresses should (in
    non-fuzzed captures) only show up once per PDU.  This part of the change fixes
    the fuzz failure.
    
    Bug: 11153
    Change-Id: I56b9854ac1342080c9f32699a3f97750fa335696
    Reviewed-on: https://code.wireshark.org/review/8748
    Petri-Dish: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 524ed1df6e6126cd63ba419ccb82c83636d77ee4)
    Conflicts:
    	epan/dissectors/packet-wccp.c
    Reviewed-on: https://code.wireshark.org/review/8770
    Reviewed-by: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    (cherry picked from commit 92483afff4394a7949667d5176bd038195c0422e)
    Reviewed-on: https://code.wireshark.org/review/9046
    Reviewed-by: Balint Reczey <balint@xxxxxxxxxxxxxxx>
    

Actions performed:

    from  f83b56a   Clean up handling of BDC coded numbers a bit.
    adds  ce1ac2c   WCCP: Fix up storing and decoding of IP addresses.


Summary of changes:
 epan/dissectors/packet-wccp.c |  138 ++++++++++++++++++-----------------------
 1 file changed, 62 insertions(+), 76 deletions(-)