Wireshark-commits: [Wireshark-commits] master 7102a06: Qt/Bluetooth: Add Devices dialogue
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 15 Jun 2015 05:40:31 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7102a06811ab63e0433ac91ad242e02c5668d259
Submitter: Michal Labedzki (michal.labedzki@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7102a06 by Michal Labedzki (michal.labedzki@xxxxxxxxx):

    Qt/Bluetooth: Add Devices dialogue
    
    Please found it under Bluetooth menu. It shows all devices found
    in logs, not only connected, all that its address can be found in
    logs. Show if device is local (in most cases: capturing on it side)
    and manufacturer and LMP version what should answer the question what
    version of Bluetooth is used by Bluetooth device chip.
    Also firmware version.
    
    Change-Id: I32e3b7100cdebcaa850b6541de0ab89dff41c0e1
    Reviewed-on: https://code.wireshark.org/review/8901
    Petri-Dish: Michal Labedzki <michal.labedzki@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Tested-by: Michal Labedzki <michal.labedzki@xxxxxxxxx>
    Reviewed-by: Michal Labedzki <michal.labedzki@xxxxxxxxx>
    

Actions performed:

    from  9fb6ec6   Qt: Add the ability to show preferences by module name.
    adds  7102a06   Qt/Bluetooth: Add Devices dialogue


Summary of changes:
 debian/libwireshark0.symbols                       |    5 +-
 docbook/release-notes.asciidoc                     |    7 +
 epan/dissectors/packet-bluetooth.c                 |   19 +-
 epan/dissectors/packet-bluetooth.h                 |   42 +-
 epan/dissectors/packet-btatt.c                     |    2 +-
 epan/dissectors/packet-bthci_cmd.c                 |  169 ++++----
 epan/dissectors/packet-bthci_cmd.h                 |    4 +
 epan/dissectors/packet-bthci_evt.c                 |  350 +++++++++++++----
 epan/dissectors/packet-bthci_evt.h                 |   11 +
 epan/dissectors/packet-bthci_vendor.c              |    8 +-
 epan/dissectors/packet-btle.c                      |   16 +-
 epan/dissectors/packet-btobex.c                    |   47 +--
 epan/dissectors/packet-btsmp.c                     |   17 +-
 epan/dissectors/packet-hci_mon.c                   |    2 +-
 ui/qt/CMakeLists.txt                               |    3 +
 ui/qt/Makefile.am                                  |    2 +
 ui/qt/Makefile.common                              |    4 +
 ui/qt/Wireshark.pro                                |    3 +
 ui/qt/bluetooth_devices_dialog.cpp                 |  412 ++++++++++++++++++++
 ...ributes_dialog.h => bluetooth_devices_dialog.h} |   30 +-
 ...butes_dialog.ui => bluetooth_devices_dialog.ui} |  108 ++---
 ui/qt/main_window.h                                |    1 +
 ui/qt/main_window.ui                               |    6 +
 ui/qt/main_window_slots.cpp                        |   11 +
 24 files changed, 989 insertions(+), 290 deletions(-)
 create mode 100644 ui/qt/bluetooth_devices_dialog.cpp
 copy ui/qt/{bluetooth_att_server_attributes_dialog.h => bluetooth_devices_dialog.h} (76%)
 copy ui/qt/{bluetooth_att_server_attributes_dialog.ui => bluetooth_devices_dialog.ui} (67%)