Wireshark-commits: [Wireshark-commits] master 8e746bd: MPLS: always display payload when no 'Decode
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 13 Jun 2015 16:15:45 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8e746bdd20d2619d4b163164011909781ec46134
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8e746bd by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    MPLS: always display payload when no 'Decode As' preference is set
    
    Based on the heuristic suggested by Jasper, check whether ethertype matches
    IPv4, ARP, RARP, VLAN or IPv6 and decode payload as Ethernet PW (CW heuristic)
    by default. Otherwise display payload as data by default.
    This can be overridden by the 'Decode As' configuration.
    
    Follow up of g7ca0472
    
    Bug: 11271
    Change-Id: Idb2ce1f8b967813a8f4a5e29e6005d5442729395
    Reviewed-on: https://code.wireshark.org/review/8912
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  a57398d   Fix some CMake compiler tests for Win64
    adds  8e746bd   MPLS: always display payload when no 'Decode As' preference is set


Summary of changes:
 epan/dissectors/packet-mpls.c   |   21 +++++++++++++--------
 epan/dissectors/packet-pw-eth.c |    4 +++-
 2 files changed, 16 insertions(+), 9 deletions(-)