Wireshark-commits: [Wireshark-commits] master 41ac67c: Fix insertion of subnets read from the subne
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=41ac67cbb218d9d7da4bd7d767b12c03a0096b5b
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
41ac67c by Christopher Maynard (Christopher.Maynard@xxxxxxx):
Fix insertion of subnets read from the subnets file: append to the *end* of
the list.
The patch ensures that non-duplicate subnets are appended to the end of the
list rather than as the second element, which if there had been a second
element previously, the memory for it was effectively leaked.
It also allows /32 "subnets", even though arguably the hosts file should be
used instead, but now the test in read_subnets_file() matches the assert in
subnet_entry_set().
Bug: 11247
Change-Id: I54bf1cbb34edfcf410aa634043a377c27091df51
Reviewed-on: https://code.wireshark.org/review/8802
Petri-Dish: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from e28339e tshark: add ability to display streams in EBCDIC
adds 41ac67c Fix insertion of subnets read from the subnets file: append to the *end* of the list.
Summary of changes:
epan/addr_resolv.c | 24 +++++++++++++++---------
1 file changed, 15 insertions(+), 9 deletions(-)
mode change 100644 => 100755 epan/addr_resolv.c