Wireshark-commits: [Wireshark-commits] master 0f36b1c: aeron: fix infinite loop
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 8 Jun 2015 18:32:38 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0f36b1c3942331e3509bc66e0e3d5876b5bfe9d4
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0f36b1c by Evan Huus (eapache@xxxxxxxxx):

    aeron: fix infinite loop
    
    `dissected_length` can come from the packet in some paths, meaning it can be 0
    or negative and we need to check for underflows and other such problems
    
    Bug: 11255
    Change-Id: Iba55ec1824a391ec1c717bfea5b65cc6610fc081
    Reviewed-on: https://code.wireshark.org/review/8839
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  b30d7b1   PMPROXY: check that pointer is not NULL before doing a strlen
    adds  0f36b1c   aeron: fix infinite loop


Summary of changes:
 epan/dissectors/packet-aeron.c |    3 +++
 1 file changed, 3 insertions(+)