Wireshark-commits: [Wireshark-commits] master 639fd7d: Eliminate proto_tree_add_text from some diss
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 8 Jun 2015 04:34:06 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=639fd7d60d15dc6c707dbd95af7bd811ed21f3d3
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

639fd7d by Michael Mann (mmann78@xxxxxxxxxxxx):

    Eliminate proto_tree_add_text from some dissectors.
    
    "file" dissectors are now rid of proto_tree_add_text.
    
    Change-Id: I4e0f7248135e6ce194fcafde47e538db84b964aa
    Reviewed-on: https://code.wireshark.org/review/8828
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  2c56c6f   igmp: fix memleak
    adds  639fd7d   Eliminate proto_tree_add_text from some dissectors.


Summary of changes:
 epan/dissectors/file-jpeg.c       |  257 ++++++++++++++++++++++++-------------
 epan/dissectors/packet-pvfs2.c    |  148 +++++++++++----------
 epan/dissectors/packet-slimp3.c   |   67 ++++++----
 epan/dissectors/packet-smb-pipe.c |   54 +++++---
 epan/dissectors/packet-wccp.c     |  185 +++++++++++++-------------
 5 files changed, 432 insertions(+), 279 deletions(-)