Wireshark-commits: [Wireshark-commits] master-1.12 d3117c0: iSCSI: handle repetition of InitiatorTa
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 5 Jun 2015 07:22:37 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d3117c03f51a7d7723aa38a593983f916b791204
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

d3117c0 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    iSCSI: handle repetition of InitiatorTaskTag fore request / response tracking
    
    Use a red-black tree instead of a hash map so as to take he current frame number into account
    Only insert entries in the red-black tree on first pass
    
    Bug: 11250
    Change-Id: Ic6e4a5e4f3cd4a22c2df0b8851c6651695648fa8
    Reviewed-on: https://code.wireshark.org/review/8763
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    (cherry picked from commit 5061da3f96b95b30d5d12812394ef375cd67bfc4)
    Conflicts:
    	epan/dissectors/packet-iscsi.c
    Reviewed-on: https://code.wireshark.org/review/8771
    

Actions performed:

    from  92483af   WCCP: Fix up storing and decoding of IP addresses.
    adds  d3117c0   iSCSI: handle repetition of InitiatorTaskTag fore request / response tracking


Summary of changes:
 epan/dissectors/packet-iscsi.c |   80 ++++++++++++++++++++++++++++++----------
 1 file changed, 60 insertions(+), 20 deletions(-)