Wireshark-commits: [Wireshark-commits] master 524ed1d: WCCP: Fix up storing and decoding of IP addr
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 4 Jun 2015 06:17:35 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=524ed1df6e6126cd63ba419ccb82c83636d77ee4
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

524ed1d by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    WCCP: Fix up storing and decoding of IP addresses.
    
    Try to decode as many IP addresses as we can, even if they don't fit in the
    table we store them in.
    
    Only add IP addresses in the table once.  We could theoretically reallocate
    the table but the original code seems to assume the addresses should (in
    non-fuzzed captures) only show up once per PDU.  This part of the change fixes
    the fuzz failure.
    
    Bug: 11153
    Change-Id: I56b9854ac1342080c9f32699a3f97750fa335696
    Reviewed-on: https://code.wireshark.org/review/8748
    Petri-Dish: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  e309d9e   MIME Multipart: fix display of the last IMF field
    adds  524ed1d   WCCP: Fix up storing and decoding of IP addresses.


Summary of changes:
 epan/dissectors/packet-wccp.c |  129 +++++++++++++++++++----------------------
 1 file changed, 60 insertions(+), 69 deletions(-)