Wireshark-commits: [Wireshark-commits] master 2ddf0e6: Don't put an expert info on every single raw
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 14 May 2015 01:46:53 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2ddf0e6db31b97ac8dbc0f43d87a114b6be100f9
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2ddf0e6 by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    Don't put an expert info on every single raw frame (even if it was just a Note).
    
    It's completely normal that there's no link information when you're dissecting
    raw packets.  This does leave the Raw protocol tree without any children
    (which looks a little funny) but I don't want to take it out and I don't see
    anything useful to put under it.
    
    Also change the Raw protocol item to cover all the bytes of the TVB (like the
    frame item).
    
    Change-Id: I44c1ac954c9989273d0c461ba366caba0a480ea6
    Reviewed-on: https://code.wireshark.org/review/8454
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  4a37dfc5  Qt: Add the correct column width padding.
    adds  2ddf0e6   Don't put an expert info on every single raw frame (even if it was just a Note).


Summary of changes:
 epan/dissectors/packet-raw.c |   15 +--------------
 1 file changed, 1 insertion(+), 14 deletions(-)