Wireshark-commits: [Wireshark-commits] master 613d4f3: More cleanly handle 3-byte IPv4 addresses.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 12 May 2015 22:22:12 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=613d4f385c0e9911b167985de88932a0e0798f65
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

613d4f3 by Guy Harris (guy@xxxxxxxxxxxx):

    More cleanly handle 3-byte IPv4 addresses.
    
    Make a union of the 4 bytes of the address and the address as a 32-bit
    integer, and fill in the bytes differently based on whether it's an
    interior or exterior route.  Rather than just casting a pointer to a
    byte to a pointer to a 4-byte integer - which may not be safe, as the
    byte array might not be properly aligned - just use the integer member
    of the union.
    
    Change-Id: Ic0e78a832cedb9a5a8d435a6c911409b17e41685
    Reviewed-on: https://code.wireshark.org/review/8443
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  384141b   Add casts to fix clang warnings.
    adds  613d4f3   More cleanly handle 3-byte IPv4 addresses.


Summary of changes:
 epan/dissectors/packet-igrp.c |   38 ++++++++++++++++++++++++++------------
 1 file changed, 26 insertions(+), 12 deletions(-)