Wireshark-commits: [Wireshark-commits] master e110664: Overhaul the MEGACO dissector.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 12 May 2015 15:11:12 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e1106646cda482be781836d2e752ca2586736d73
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e110664 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Overhaul the MEGACO dissector.
    
    1. Have megaco dissector display fields as their are "interpreted", not as raw data with "interpretation" as a subtree
    2. Replace/remove proto_tree_add_text
    3. Convert some "numeric string fields" into numeric values.
    4. Add some more dissection discovered while looking for sample captures.
    
    Bug: 6732
    Ping-Bug: 10909
    Change-Id: Ie051a8a16ef2355681a24be8789bae0971632cd1
    Reviewed-on: https://code.wireshark.org/review/8382
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  8f962a7   PIM: Remove trailing whitespace before comma
    adds  e110664   Overhaul the MEGACO dissector.


Summary of changes:
 epan/dissectors/packet-megaco.c | 1259 ++++++++++++++++++++-------------------
 1 file changed, 634 insertions(+), 625 deletions(-)