Wireshark · Wireshark-commits: [Wireshark-commits] master 42611db: Try wrapping some tshark invocations in a script to catch crashe

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=42611db19ae539799de2a66fc53edecfdf9a27a9
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

42611db by Guy Harris (guy@xxxxxxxxxxxx):

    Try wrapping some tshark invocations in a script to catch crashes.
    
    Add a script that takes a command as an argument and runs it in a
    subshell, so that said subshell will catch any signals from it and
    report it.
    
    This would be done for commands that aren't the last command in the
    pipeline, as, given that the exit status of a pipeline is the exit
    status of the last command in the pipeline, there's no guarantee that
    the shell will bother to pick up the exit status of earlier commands in
    the pipeline.
    
    Use that for the tshark in the WPA EAPOL Rekey test, so it at least can
    report the signal (on Solaris, SIGSEGV means, among other things,
    "dereferenced a pointer pointing out of the address space" and SIGBUS
    means, among other things, "dereferenced a misaligned pointer on
    SPARC").  Maybe we can make the script also fire up a debugger if it
    finds a core dump (and a debugger) and get a stack trace.
    
    Change-Id: I4188190a1f1a4d3afc4719d886161ee56bd89d8b
    Reviewed-on: https://code.wireshark.org/review/8392
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  040641d   Copy PTK key in its dedicated array, and not at the address of the array
    adds  42611db   Try wrapping some tshark invocations in a script to catch crashes.


Summary of changes:
 test/run_and_catch_crashes |   20 ++++++++++++++++++++
 test/suite-decryption.sh   |    2 +-
 2 files changed, 21 insertions(+), 1 deletion(-)
 create mode 100755 test/run_and_catch_crashes