Wireshark-commits: [Wireshark-commits] master 7d4e0c7: Pick array sizes based on what they're suppo
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 10 May 2015 18:01:09 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7d4e0c73a3479560b6870f6d3cc7c2bdaab810b3
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7d4e0c7 by Guy Harris (guy@xxxxxxxxxxxx):

    Pick array sizes based on what they're supposed to hold.
    
    In AirPDcapRsnaPwd2PskStep(), digest[] holds an SSID plus 4 bytes of
    count, so the size is MAX_SSID_LENGTH plus 4, and digest1[] holds an
    SHA-1 digest, so the size is SHA1_DIGEST_LEN.
    
    That makes it a bit clearer why those are the sizes.
    
    Change-Id: I58ed6643f57675375f7f369470d600382323315f
    Reviewed-on: https://code.wireshark.org/review/8387
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  c01f369   qt: minor string change in capture options
    adds  7d4e0c7   Pick array sizes based on what they're supposed to hold.


Summary of changes:
 epan/crypt/airpdcap.c |   13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)