Wireshark-commits: [Wireshark-commits] master f77e02c: Expert Info dialog.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 8 May 2015 04:30:09 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f77e02ccc62c9283eefba416efbb2f94e460066e
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f77e02c by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Expert Info dialog.
    
    Show all expert messages in a combined view. Group top-level items by a
    (severity, group, protocol) tuple.
    
    Let the user enable and disable messages via a check menu.
    
    Add ProtoTree::goToField and expert_info_t.hf_index. Use them to jump to
    what we hope is the afflicted item.
    
    Enable the context menu only if the user has selected a packet item.
    
    Add a free-form search field that matches expert summaries.
    
    This differs from the GTK+ version but hopefully provides a smoother
    workflow.
    
    Bug: 10931
    Change-Id: Ia12cb7c27cdea1634fa2798fb7e4c1b23bd16ad2
    Reviewed-on: https://code.wireshark.org/review/8294
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  3d7ff97   nghttp2: use g_ntoh[ls], g_hton[ls] from glib
    adds  f77e02c   Expert Info dialog.


Summary of changes:
 epan/expert.c                                      |    1 +
 epan/expert.h                                      |    1 +
 ui/gtk/expert_comp_dlg.c                           |    2 +-
 ui/gtk/expert_comp_table.c                         |    2 +-
 ui/qt/CMakeLists.txt                               |    3 +
 ui/qt/Makefile.am                                  |    2 +
 ui/qt/Makefile.common                              |    4 +
 ui/qt/Wireshark.pro                                |    3 +
 ui/qt/color_utils.cpp                              |    8 +
 ui/qt/color_utils.h                                |    9 +
 ui/qt/display_filter_edit.h                        |    1 -
 ui/qt/expert_info_dialog.cpp                       |  581 ++++++++++++++++++++
 ...col_hierarchy_dialog.h => expert_info_dialog.h} |   99 ++--
 ui/qt/expert_info_dialog.ui                        |  221 ++++++++
 ui/qt/main_status_bar.cpp                          |    5 +-
 ui/qt/main_status_bar.h                            |    1 +
 ui/qt/main_window.cpp                              |    3 +
 ui/qt/main_window.h                                |    2 +
 ui/qt/main_window.ui                               |   10 +
 ui/qt/main_window_slots.cpp                        |   28 +
 ui/qt/packet_list.cpp                              |    6 +
 ui/qt/packet_list.h                                |    1 +
 ui/qt/proto_tree.cpp                               |   41 +-
 ui/qt/proto_tree.h                                 |    1 +
 24 files changed, 975 insertions(+), 60 deletions(-)
 create mode 100644 ui/qt/expert_info_dialog.cpp
 copy ui/qt/{protocol_hierarchy_dialog.h => expert_info_dialog.h} (50%)
 create mode 100644 ui/qt/expert_info_dialog.ui