Wireshark-commits: [Wireshark-commits] master 0d6581c: Add a note about slot naming.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 3 May 2015 18:32:36 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0d6581c152cf57bac655414862db92a5a66d83b2
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0d6581c by Gerald Combs (gerald@xxxxxxxx):

    Add a note about slot naming.
    
    Note that QMetaObject::connectSlotsByName looks for slots which follow a
    specific naming convetion, and that manually connected slots should not
    use that convention. This isn't obvious and seems to trip people up from
    time to time.
    
    Change-Id: I81f05519fcba672dcca8ccd82bbafa4d1559cebf
    Reviewed-on: https://code.wireshark.org/review/8279
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  26a3573   Add support for IPv6 heuristic dissectors.
    adds  0d6581c   Add a note about slot naming.


Summary of changes:
 ui/qt/main_window.h |   15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)