Wireshark-commits: [Wireshark-commits] master 27e480c: Handle PIMvN, for N > 2, by just adding the
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 2 May 2015 09:48:44 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=27e480cf5a29563cf2ee4ff30c8bfd31b81631f9
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

27e480c by Guy Harris (guy@xxxxxxxxxxxx):

    Handle PIMvN, for N > 2, by just adding the checksum and subtree and bailing.
    
    Don't bother doing the checksum, as we don't know how much to checksum;
    don't assume setting pim_length to 0 will force it not to be
    checksummed, as it doesn't; and don't test twice for a version != 2.
    
    Change-Id: I1c2ed3ecf1572aef6c5af140c410f9cdd0e9c3a6
    Reviewed-on: https://code.wireshark.org/review/8271
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  6e66cda   No need to call tvb_reported_length() twice.
    adds  27e480c   Handle PIMvN, for N > 2, by just adding the checksum and subtree and bailing.


Summary of changes:
 epan/dissectors/packet-pim.c |   52 ++++++++++++++++++++++--------------------
 1 file changed, 27 insertions(+), 25 deletions(-)