Wireshark-commits: [Wireshark-commits] master 510777c: Fix some cases where we're shifting a signed
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=510777cf78488981db12cb98267599aca9866783
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
510777c by Guy Harris (guy@xxxxxxxxxxxx):
Fix some cases where we're shifting a signed 1 left.
Shift 1U instead, to make sure it's unsigned; the result of, for
example, the result of shifting a signed value left is undefined if the
value times 2^{shift count} doesn't fit in the *signed* type of the
shifted value. That means, in particular, that the result of shifting 1
left by {number of bits in an int - 1} is undefined. (In *practice*,
it'll probably be -2^32, with the bit you want set, but that's not
guaranteed, and GCC 5.1 seems not to like it.)
This fixes the generator for the X11 header files; we manually fix the
header file in question, because life's too short to spend very much of
it trying to debug Perl issues that cause a
Can't use string ("1") as a HASH ref while "strict refs" in use at
../../tools/process-x11-xcb.pl line 675.
at ../../tools/process-x11-xcb.pl line 1859
at ../../tools/process-x11-xcb.pl line 1859
failure.
Change-Id: Ia903e9dacad49021bc0dfe129b9393ad426de9eb
Reviewed-on: https://code.wireshark.org/review/8261
Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
Actions performed:
from f708c5c rv is only used in an assert. The assert only evaluates to code if NDEBUG is undefined. Protect rv and its use accordingly.
adds 510777c Fix some cases where we're shifting a signed 1 left.
Summary of changes:
epan/dissectors/x11-register-info.h | 4136 +++++++++++++++++------------------
tools/process-x11-xcb.pl | 2 +-
2 files changed, 2069 insertions(+), 2069 deletions(-)
