Wireshark-commits: [Wireshark-commits] master 7f6fe7a: Reorganize some of the Diameter XML files, t
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 29 Apr 2015 11:37:34 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7f6fe7a1fd9db03a48b044e2966561336fa39298
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7f6fe7a by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    Reorganize some of the Diameter XML files, taking advantage of the fact that
    AVPs can be grouped by Vendor now (not just by Application).
    
    Move a bunch of vendor-specific Application IDs to the vendor's XML file.
    
    Delete the (basically empty) SKT.xml, ChinaTelecom.xml, and VerizonWireless.xml
    files.
    
    Fix a typo: 16777224 is 3GPP Gx, not 3GPP Cx.
    
    Use (derived) type Enumerated (rather than Unsigned32 or Integer32) when the
    AVP is of type Enumerated.
    
    Change-Id: I7a9702c0c48dc3fe751ad74413d8ecc040984f1f
    Reviewed-on: https://code.wireshark.org/review/8235
    Petri-Dish: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  fbec73d   cli_service_response_time_table.h: fix api reference
    adds  7f6fe7a   Reorganize some of the Diameter XML files, taking advantage of the fact that AVPs can be grouped by Vendor now (not just by Application).


Summary of changes:
 Makefile.am                            |    5 +-
 diameter/AlcatelLucent.xml             |    2 +
 diameter/ChinaTelecom.xml              |    8 -
 diameter/Ericsson.xml                  |  283 +-
 diameter/HP.xml                        |    2 +
 diameter/Nokia.xml                     |    9 +-
 diameter/NokiaSolutionsAndNetworks.xml |    6 +-
 diameter/Oracle.xml                    |    2 +-
 diameter/SKT.xml                       |    8 -
 diameter/Starent.xml                   | 4445 ++++++++++++++++----------------
 diameter/TGPP.xml                      |  168 +-
 diameter/TGPP2.xml                     |    7 +-
 diameter/VerizonWireless.xml           |   10 -
 diameter/Vodafone.xml                  |    2 +-
 diameter/chargecontrol.xml             |    6 +-
 diameter/dictionary.xml                |   41 +-
 diameter/etsie2e4.xml                  |   53 +-
 diameter/mobileipv4.xml                |   16 +-
 diameter/sunping.xml                   |    2 +
 packaging/nsis/wireshark.nsi           |    3 -
 20 files changed, 2523 insertions(+), 2555 deletions(-)
 delete mode 100644 diameter/ChinaTelecom.xml
 delete mode 100644 diameter/SKT.xml
 delete mode 100644 diameter/VerizonWireless.xml