Wireshark-commits: [Wireshark-commits] master 0b368ea: Add service_response_time_table for TShark s
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 28 Apr 2015 07:37:19 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0b368ea23ff86d1895f6c8572a1014490b574d31
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0b368ea by Michael Mann (mmann78@xxxxxxxxxxxx):

    Add service_response_time_table for TShark srt stats.
    
    This is a "refactoring part 1" of the srt stats.  This first step is using the service_response_time_table for all (possible) TShark srt stats.  Next step will be combining the GTK and TShark service_response_time_table, so there is more code reuse and the "shared structure names" between GTK and TShark service_response_time_table won't seem as bad.
    
    Maybe it can even go one step farther and handle a dynamic number of columns so this refactoring can apply to all srt stats.
    
    Change-Id: Ief28e7e55f7dbbf4f2d9bb6f1a1592b87b866137
    Reviewed-on: https://code.wireshark.org/review/8210
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  8c996a2   Add tshark -z "smb2,srt"
    adds  0b368ea   Add service_response_time_table for TShark srt stats.


Summary of changes:
 CMakeLists.txt                                     |    1 +
 ui/cli/Makefile.common                             |    4 +-
 ui/cli/cli_service_response_time_table.c           |  166 +++++++++++++++++++
 .../cli_service_response_time_table.h}             |   31 ++--
 ui/cli/tap-afpstat.c                               |   79 ++-------
 ui/cli/tap-ldapstat.c                              |   67 ++------
 ui/cli/tap-rpcstat.c                               |  146 ++---------------
 ui/cli/tap-scsistat.c                              |  151 ++++--------------
 ui/cli/tap-smbstat.c                               |  167 +++-----------------
 9 files changed, 274 insertions(+), 538 deletions(-)
 create mode 100644 ui/cli/cli_service_response_time_table.c
 copy ui/{gtk/service_response_time_table.h => cli/cli_service_response_time_table.h} (77%)