Wireshark-commits: [Wireshark-commits] master 0e572cb: androiddump: Fix warning about unneeded valu
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 23 Apr 2015 09:02:05 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0e572cbcbf125ceb37d11638b5f05e646da1fc5d
Submitter: Michal Labedzki (michal.labedzki@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0e572cb by Michal Labedzki (michal.labedzki@xxxxxxxxx):

    androiddump: Fix warning about unneeded value
    
    Value from strtol is not needed in this case, but compiler
    complains about it, so check if value range is valid and other
    possible error that can be detected.
    
    Change-Id: I6a8eeb6d2cb62c155772201000eca4c16bc8a555
    Reviewed-on: https://code.wireshark.org/review/8172
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michal Labedzki <michal.labedzki@xxxxxxxxx>
    

Actions performed:

    from  4ea4ddb   Added syntax id 0x82 for NCK data access
    adds  0e572cb   androiddump: Fix warning about unneeded value


Summary of changes:
 extcap/androiddump.c |   32 ++++++++++++++++++++++++++------
 1 file changed, 26 insertions(+), 6 deletions(-)