Wireshark-commits: [Wireshark-commits] master-1.12 5bbf0d2: reassembly: address a 15-year old XXX c
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 22 Apr 2015 21:37:59 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5bbf0d2afbf31f50eed0d46a56a2a1e8f494901a
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

5bbf0d2 by Evan Huus (eapache@xxxxxxxxx):

    reassembly: address a 15-year old XXX comment
    
    Question: "what if we didn't capture the entire fragment due to a too-short
              snapshot length?"
    Answer: An assertion fails and we leak a bunch of memory.
    
    Don't do that.
    
    Bug: 11129
    Change-Id: I0adfb217f0e66ae8f5f6255a4caf7ff940826b59
    Reviewed-on: https://code.wireshark.org/review/8128
    Petri-Dish: Evan Huus <eapache@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    (cherry picked from commit c35f2ccb4433718416551cc7a85afb0860529d57)
    Reviewed-on: https://code.wireshark.org/review/8149
    

Actions performed:

    from  53597ca   Make various structure members the right size for time-in-seconds.
    adds  5bbf0d2   reassembly: address a 15-year old XXX comment


Summary of changes:
 epan/reassemble.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)