Wireshark · Wireshark-commits: [Wireshark-commits] master 847e517: Allow the definition of AVPs within vendor IDs.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=847e5179dcbfb4f36137cae98502749f254fbab2
Submitter: Jeff Morriss (jeff.morriss.ws@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

847e517 by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    Allow the definition of AVPs within vendor IDs.
    
    This allows for a more natural organization of AVP definitions: they can now
    be grouped by application (including the base application) or vendor ID. This
    means we can stop using the "workaround" (for those vendors who define AVPs
    but don't have their own application ID) of finding some random application ID
    to put in a vendor-specific xml file just to satisfy the parser.
    
    Rework a couple of Vendor-specific xml files as an example.
    
    Note: this does mean that vendor IDs can no longer be defined inside of the
    base or other application.  If that's a problem the parser could be made
    (through some duplication of code) to understand the old format too.
    
    Change-Id: I5119f0dc7f8e3bbf59e2207046a8bb0f42ab0ca1
    Reviewed-on: https://code.wireshark.org/review/8141
    Petri-Dish: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    

Actions performed:

    from  8b72091   Calculate *Peek tagged timestamps in fixed-point.
    adds  847e517   Allow the definition of AVPs within vendor IDs.


Summary of changes:
 diameter/Cisco.xml           |  845 +++++++++++++++++++++---------------------
 diameter/Oracle.xml          |   12 +-
 diameter/VerizonWireless.xml |   12 +-
 diameter/Vodafone.xml        |    2 +
 diameter/dictionary.xml      |   67 ++--
 epan/diam_dict.l             |   25 +-
 6 files changed, 486 insertions(+), 477 deletions(-)