Wireshark-commits: [Wireshark-commits] master 1edbd5a: Don't use proto_tree_add_uint() to add FT_BO
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 19 Apr 2015 21:27:24 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1edbd5a875af00d1972eb24c43d94f2b6c5220f9
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

1edbd5a by Guy Harris (guy@xxxxxxxxxxxx):

    Don't use proto_tree_add_uint() to add FT_BOOLEAN values.
    
    In proto_item_add_bitmask_tree(), if use_value is true, base the routine
    we use to add the item to the tree on the type of the field being added.
    
    Also, use DISSECTOR_ASSERT_NOT_REACHED(), not g_assert_not_reached(), to
    catch types that aren't integral or Boolean.
    
    Change-Id: I6ff9867bddcae16ddf8b689b48fdc93c6f949105
    Reviewed-on: https://code.wireshark.org/review/8127
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  9194aab   Use 64-bit fixed point to calculate time stamps.
    adds  1edbd5a   Don't use proto_tree_add_uint() to add FT_BOOLEAN values.


Summary of changes:
 epan/proto.c |   34 +++++++++++++++++++++++++++++++---
 1 file changed, 31 insertions(+), 3 deletions(-)