Wireshark · Wireshark-commits: [Wireshark-commits] master 6ab6136: Add more "bitmask grouping" APIs.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6ab6136a94ec4ca7481a837f348050091505c6e0
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

6ab6136 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Add more "bitmask grouping" APIs.
    
    Add proto_tree_add_bitmask_value, proto_tree_add_bitmask_value_with_flags and proto_tree_add_bitmask_list to aid in the removal of proto_tree_add_boolean "groupings" as well as "groups" of fields that use proto_tree_add_item with the same offset/len.
    
    This may be able to be optimized later, but the first step will be converting dissectors to use it.  A sample conversion of each API is also included.
    
    Change-Id: I53febc7450ad632482f82615a7fa62174f8472c9
    Reviewed-on: https://code.wireshark.org/review/8038
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  89cd92d   GSM A: force display of the bits sequence corresponding to "Degrees of longitude" field
    adds  6ab6136   Add more "bitmask grouping" APIs.


Summary of changes:
 debian/libwireshark0.symbols        |    3 +
 epan/dissectors/packet-dect.c       |  107 +++++++++++++++++++---------------
 epan/dissectors/packet-sita.c       |   31 ++++++----
 epan/dissectors/packet-smb-browse.c |   88 ++++++++++------------------
 epan/proto.c                        |  108 +++++++++++++++++++++++++----------
 epan/proto.h                        |   70 +++++++++++++++++++++++
 6 files changed, 260 insertions(+), 147 deletions(-)