Wireshark-commits: [Wireshark-commits] master 1f45a37: Replace PROTO_TREE_ADD_XXX_ITEM macro use wi
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 9 Apr 2015 18:27:06 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1f45a377137efe8c2c17c6bb9de39a8425e5acab
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

1f45a37 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Replace PROTO_TREE_ADD_XXX_ITEM macro use with real code.
    
    PROTO_TREE_ADD_XXX_ITEM had a bug in it for int values.  This was
    fixed by adding proto_tree_set_ ## ctype ## to the macro, but not
    all compilers support macros at the end of a function, so just
    remove the macro entirely and just have the duplicate code.
    
    Change-Id: Icf92a6786daa0e84305ba174ce155833f90b6463
    Reviewed-on: https://code.wireshark.org/review/8006
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  eb0489b   Correct macro expansion in PROTO_TREE_ADD_XXX_ITEM for integer fields.
    adds  1f45a37   Replace PROTO_TREE_ADD_XXX_ITEM macro use with real code.


Summary of changes:
 epan/proto.c |  103 +++++++++++++++++++++++++++++++++++-----------------------
 1 file changed, 63 insertions(+), 40 deletions(-)