Wireshark-commits: [Wireshark-commits] master c67bc03: Let capture_dev_user_pmode_find() say "not f
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 4 Apr 2015 21:03:38 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c67bc0335566113fc325830660f5571d2e6ad0f6
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c67bc03 by Guy Harris (guy@xxxxxxxxxxxx):

    Let capture_dev_user_pmode_find() say "not found".
    
    "Not found" is different from "found, and false".  Have it return a
    boolean "did I find the property" indication and, if it did, supply the
    property value through a pointer.
    
    Change-Id: Iaa942ea346410b35e512ff1a3821cbf60c88dfd6
    Reviewed-on: https://code.wireshark.org/review/7916
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  666f9bc   dumpcap: fix no previous prototype for ‘is_linux_bonding_device’ [-Wmissing-prototypes]
    adds  c67bc03   Let capture_dev_user_pmode_find() say "not found".


Summary of changes:
 ui/capture_ui_utils.c               |   12 ++++++++++--
 ui/capture_ui_utils.h               |    8 +++++++-
 ui/gtk/capture_dlg.c                |    5 ++---
 ui/gtk/prefs_capture.c              |    9 ++++-----
 ui/iface_lists.c                    |    2 +-
 ui/qt/capture_interfaces_dialog.cpp |    3 +--
 6 files changed, 25 insertions(+), 14 deletions(-)