Wireshark-commits: [Wireshark-commits] master 752f5de: Fix bug #10858. There were several cases whe
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 1 Apr 2015 03:03:23 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=752f5de7194c96803a7c350d8b9e67b2203a01bf
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

752f5de by Richard Sharpe (realrichardsharpe@xxxxxxxxx):

    Fix bug #10858. There were several cases where uint32 fields were mistaken
    for two uint16 fields and three fields were merged into one as an unknown.
    There was also an unnecessary unknown field on the end that caused a
    malformed packet exception to occur.
    
    Tested with a capture of a rename.
    
    Bug: 10858
    
    Change-Id: Ibcf22270d2c34605bb47e3a9804b53746597572d
    Signed-off-by: Richard Sharpe <realrichardsharpe@xxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/7837
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  c5b35c2   afp: 64-bit values require 64-bit value strings
    adds  752f5de   Fix bug #10858. There were several cases where uint32 fields were mistaken for two uint16 fields and three fields were merged into one as an unknown. There was also an unnecessary unknown field on the end that caused a malformed packet exception to occur.


Summary of changes:
 epan/dissectors/packet-smb2.c |   57 ++++++++++++++++++++++++++---------------
 1 file changed, 37 insertions(+), 20 deletions(-)