Wireshark-commits: [Wireshark-commits] master d3517fd: wsp: fix format string
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 28 Mar 2015 16:30:22 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d3517fde834fb4300190d1175bc07662c6013659
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d3517fd by Evan Huus (eapache@xxxxxxxxx):

    wsp: fix format string
    
    I76f7515889727dc7fad27ac90ca96750384a46f3 made the format strings static using
    macros, but missed the fact that sprintf("%s foo", bar) should become
    (bar " foo") and not ("%s foo" bar). This caused a malformed value string
    fallback.
    
    Bug: 11092
    Change-Id: Idba3c87a32a6b3c852e661a62e8cd9be6cad0904
    Reviewed-on: https://code.wireshark.org/review/7836
    Petri-Dish: Evan Huus <eapache@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  b8ccc2a   x11: destroy two more hash tables in convo data
    adds  d3517fd   wsp: fix format string


Summary of changes:
 epan/dissectors/packet-wsp.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)