Wireshark-commits: [Wireshark-commits] lts-1.12.1 2c9b3f3: Do bounds checking when decompressing WC
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 23 Mar 2015 09:45:26 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2c9b3f3e3f753723ecfd0927b668ae2af6ee5830
Submitter: Balint Reczey (balint@xxxxxxxxxxxxxxx)
Changed: branch: lts-1.12.1
Repository: wireshark

Commits:

2c9b3f3 by Guy Harris (guy@xxxxxxxxxxxx):

    Do bounds checking when decompressing WCP packets.
    
    Extract the data offset and count only once, and make sure we don't run
    past the end of the data we've copied from the packet; have
    decompressed_entry() just do the decompression, rather than also
    fetching the data offset and count.
    
    Add some comments while we're at it.
    
    Bug: 10844
    Change-Id: I2dc2f9594422ffa8f15fd5c57c9dac2e30e363f4
    Reviewed-on: https://code.wireshark.org/review/6514
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit b204ff4846fe84b7789893c6b1d9afbdecac5b5d)
    Reviewed-on: https://code.wireshark.org/review/6515
    Reviewed-on: https://code.wireshark.org/review/7703
    Reviewed-by: Balint Reczey <balint@xxxxxxxxxxxxxxx>
    Tested-by: Balint Reczey <balint@xxxxxxxxxxxxxxx>
    

Actions performed:

    from  5b715e7   FT_{U}INT64 doesn't work with BASE_CUSTOM.
    adds  2c9b3f3   Do bounds checking when decompressing WCP packets.


Summary of changes:
 epan/dissectors/packet-wcp.c |  116 +++++++++++++++++++++++++++++-------------
 1 file changed, 82 insertions(+), 34 deletions(-)