Wireshark-commits: [Wireshark-commits] master-1.12 7b6e7b1: Centralize the code to set the active_d
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 23 Mar 2015 00:07:01 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7b6e7b16d79a87f8e62803da622a1ff348c913c6
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

7b6e7b1 by Guy Harris (guy@xxxxxxxxxxxx):

    Centralize the code to set the active_dlt value for a device.
    
    We were doing it similarly, but not the same, in several places; make a
    common routine for it.
    
    Have that code check to make sure the DLT_ value in question is actually
    supported by the device; if not, pick the first supported DLT_ value, if
    any; this keeps it from, for example, picking a bad DLT_ value if your
    defaults were set based on monitor mode being on but monitor mode
    actually being off, or vice versa.
    
    Change-Id: I1c58a97eda67555259d0dfdeaa02a850c0c96b5a
    Reviewed-on: https://code.wireshark.org/review/7796
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  98ded73   [Automatic manuf, services and enterprise-numbers update for 2015-03-22]
    adds  7b6e7b1   Centralize the code to set the active_dlt value for a device.


Summary of changes:
 capture_ui_utils.c                  |   51 +++++++++++++++++++++++++++++++++++
 capture_ui_utils.h                  |    7 +++++
 ui/gtk/capture_dlg.c                |    4 +--
 ui/iface_lists.c                    |   23 ++++------------
 ui/qt/capture_interfaces_dialog.cpp |    2 ++
 5 files changed, 66 insertions(+), 21 deletions(-)