Wireshark-commits: [Wireshark-commits] master baa8391: Eliminate decode_bitfield_value from "public
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 19 Mar 2015 04:33:30 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=baa83912e3ba3c5146342eb7e1e30f56b462587f
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

baa8391 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Eliminate decode_bitfield_value from "public" use.
    
    This "encourages" (forces) dissectors to use the bitmask field of the header_field_info structure to get "bitmask formatting" of a field.
    
    other_decode_bitfield_value should be treated the same (eventually eliminated), but there are still replacements to be made in the dissectors.
    
    Change-Id: I8a0d829c3fef2d5e5a588667a259e231bca559e6
    Reviewed-on: https://code.wireshark.org/review/7736
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  a1ea3ce   Fix another call to capture_dev_user_snaplen_find().
    adds  baa8391   Eliminate decode_bitfield_value from "public" use.


Summary of changes:
 debian/libwireshark0.symbols |    1 -
 epan/proto.c                 |   11 +++++++++++
 epan/to_str.c                |   11 -----------
 epan/to_str.h                |    2 --
 4 files changed, 11 insertions(+), 14 deletions(-)