Wireshark-commits: [Wireshark-commits] master 1fdfee6: Patch some memory leaks.
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 19 Mar 2015 00:28:45 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1fdfee69d6a96b66719d34651dfa4bdc852a23ae
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

1fdfee6 by Guy Harris (guy@xxxxxxxxxxxx):

    Patch some memory leaks.
    
    capture_dev_user_descr_find() and capture_dev_user_cfilter_find() return
    g_malloc()ated strings; we don't need to g_strdup() them to get a
    g_malloc()ated string, and we *do* need to free them if we aren't going
    to use them any more.
    
    Document that while we're at it, and give more details for the functions
    returning integer user-specified interface parameters as well.
    
    Change-Id: Icf98a48992b1c4168ead54bdc4cc2847da89d665
    Reviewed-on: https://code.wireshark.org/review/7745
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  ab45f1d   Unused parameters are done differently in C++.
    adds  1fdfee6   Patch some memory leaks.


Summary of changes:
 ui/capture_ui_utils.c               |   88 +++++++++++++++++------------------
 ui/capture_ui_utils.h               |   27 +++++++++++
 ui/qt/capture_interfaces_dialog.cpp |    2 +-
 ui/qt/manage_interfaces_dialog.cpp  |    1 +
 4 files changed, 73 insertions(+), 45 deletions(-)