Wireshark-commits: [Wireshark-commits] master-1.12 9a24e2c: Assert that the row number passed to pa
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 12 Mar 2015 17:33:39 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9a24e2c60484a10515093fd5d37e11ba75283106
Submitter: Jeff Morriss (jeff.morriss.ws@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

9a24e2c by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    Assert that the row number passed to packet_list_get_row_data() is valid.
    
    Unfortunately that row number may come from a dissector/tap but allowing us
    to continue just causes us to die horribly later (and we can't except out of
    processing a tap).
    
    Change-Id: I37f03385db55dbe55f91e2ec6a03add5664857ba
    Ping-Bug: 10885
    Reviewed-on: https://code.wireshark.org/review/7652
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 8e709fca69dcd485192ff164662095e1e6f0c5c6)
    Reviewed-on: https://code.wireshark.org/review/7656
    Reviewed-by: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    

Actions performed:

    from  7c670bb   Fix buffer overflow in 802.11 decryption
    adds  9a24e2c   Assert that the row number passed to packet_list_get_row_data() is valid.


Summary of changes:
 ui/gtk/packet_list.c |    1 +
 1 file changed, 1 insertion(+)