Wireshark-commits: [Wireshark-commits] master 56a9036: Qt: fix CPU hogging due to status bar
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 7 Mar 2015 16:56:02 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=56a903608cfabf5d5f468eaebcf28f2e7160c49a
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

56a9036 by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt: fix CPU hogging due to status bar
    
    http://doc.qt.io/qt-5/qwidget.html#updatesEnabled-prop says:
    
        "Re-enabling updates implicitly calls update() on the widget."
    
    This results in an infinite paintEvent series, hogging the CPU. Updating
    the text twice does not seem to be a bad idea after all...
    
    Change-Id: Id6cd733e68512f6963fc7d70d91859ca88ab8d38
    Reviewed-on: https://code.wireshark.org/review/7581
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  1f00574   GSM SMS: minor fixes to DELIVER, DELIVER REPORT and STATUS_REPORT dissection
    adds  56a9036   Qt: fix CPU hogging due to status bar


Summary of changes:
 ui/qt/label_stack.cpp |    2 --
 1 file changed, 2 deletions(-)