Wireshark-commits: [Wireshark-commits] master c4cab87: [ICMP] icmp_original_dgram_length is being u
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 5 Mar 2015 16:33:19 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c4cab879c968ecd119b4fd48313394f0d1c61aca
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c4cab87 by Anish Bhatt (anish@xxxxxxxxxxx):

    [ICMP] icmp_original_dgram_length is being used incorrectly
    
    icmp_original_dgram_length is of no use, we need to always account for
    icmp_original_dgram_length + ip header, where icmp_original_dgram_length
    is available
    
    Bug: 10991
    Change-Id: Ibd0ce538eaf1a7851e4f3e928bad29310ebbcc81
    Reviewed-on: https://code.wireshark.org/review/7345
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  b679295   [ICMP] Don't use icmp_original_dgram_length for redirect packet
    adds  c4cab87   [ICMP] icmp_original_dgram_length is being used incorrectly


Summary of changes:
 epan/dissectors/packet-icmp.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)