Wireshark · Wireshark-commits: [Wireshark-commits] master 30ed6a1: Qt: Apply recent settings.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=30ed6a1d72f1a231e5c6cb7993239e95cd3c6038
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

30ed6a1 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Apply recent settings.
    
    Add PacketList::applyRecentColumnWidths which set the packet list
    column widths from our recent settings. Make sure it gets called at
    startup and when we change profiles.
    
    Save the packet list header state so that we can restore it when we
    reset the model (i.e. freezing and thawing) and load a new capture file.
    Save the state when the user resizes a column. As a side effect this
    works around a weird bug that adjusts the width of column 1 at an
    inopportune time.
    
    Add a profileChanging signal so that we can save the main window geometry
    in each profile.
    
    Get rid of MainWindow::configurationProfileChanged. It was unused.
    
    Apply saved pane widths and heights. Note that we might want to add a
    separate pair of recent settings for the Qt panes.
    
    Use the last opened directory in the capture file dialog.
    
    Git rid of some unneeded Q_UNUSEDs while we're here.
    
    Bug: 10953
    Change-Id: I812aff59818cf0b4d1598b580627d32728d2e9d7
    Reviewed-on: https://code.wireshark.org/review/7247
    Reviewed-by: Michal Labedzki <michal.labedzki@xxxxxxxxx>
    Tested-by: Michal Labedzki <michal.labedzki@xxxxxxxxx>
    Petri-Dish: Michal Labedzki <michal.labedzki@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  f9fc252   exntest: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
    adds  30ed6a1   Qt: Apply recent settings.


Summary of changes:
 cfile.h                         |    2 +-
 ui/qt/capture_file_dialog.cpp   |    1 +
 ui/qt/main_status_bar.cpp       |    2 +-
 ui/qt/main_window.cpp           |   16 +++++-
 ui/qt/main_window.h             |   17 +++---
 ui/qt/main_window_slots.cpp     |  110 ++++++++++++++++++++++-----------------
 ui/qt/packet_list.cpp           |   90 +++++++++++++++++++++-----------
 ui/qt/packet_list.h             |    5 +-
 ui/qt/packet_list_model.cpp     |    3 +-
 ui/qt/wireshark_application.cpp |   10 ++--
 ui/qt/wireshark_application.h   |    5 +-
 wireshark-qt.cpp                |    4 +-
 12 files changed, 164 insertions(+), 101 deletions(-)