Wireshark-commits: [Wireshark-commits] master fd870e3: CMIP: get rid of some evil global variables
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 17 Feb 2015 20:28:50 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fd870e34e865e5d8e1114b8b6d9394355989a617
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

fd870e3 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    CMIP: get rid of some evil global variables
    
    Fixes an ASAN failure reported by Alexis
    Note that some global variables remain as I do not know enough on this protocol to safely remove them
    
    Change-Id: If392a8f09ef2fc2f2d46871a71149e29fe5e292c
    Reviewed-on: https://code.wireshark.org/review/7099
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  edf05db   Corrected display format for EUI-64
    adds  fd870e3   CMIP: get rid of some evil global variables


Summary of changes:
 asn1/cmip/cmip.cnf               |   38 +++++++------
 asn1/cmip/packet-cmip-template.c |   13 -----
 epan/dissectors/packet-cmip.c    |  116 +++++++++++++++-----------------------
 3 files changed, 67 insertions(+), 100 deletions(-)